Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the gossip system to use lock-free data structures for improved performance in read-heavy scenarios. It replaces RwLock synchronization with ArcSwap for the membership and hash ring data structures to reduce lock contention and eliminate unnecessary cloning.
- Replace
RwLock<Membership>andRwLock<Arc<HashRing<Uuid>>>withArcSwapvariants - Add utility methods to
Membershipfor better integration with the new lock-free approach - Update all membership and ring access patterns to use atomic operations instead of read/write locks
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/gossip/src/member.rs | Adds into_members() method and FromIterator implementation for Membership |
| crates/gossip/src/gossip.rs | Replaces RwLock with ArcSwap for membership and ring, updates all access patterns |
| crates/gossip/Cargo.toml | Adds arc-swap dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tisonkun
reviewed
Oct 15, 2025
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Would this technique applicible for client's route table state also?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Membership and HashRing are read-heavy data structures. Use lock-free multi version to reduce lock usage and full clone.